[PATCH] D21732: [ELF] Initial support for wildcard in symbol versions

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.h:101
@@ +100,3 @@
+
+bool matchStr(StringRef S, StringRef T);
+
----------------
This should be defined in lld::elf namespace.

================
Comment at: ELF/SymbolTable.cpp:468-469
@@ +467,4 @@
+  if (!HasWildcards) {
+    Result.push_back(find(Pattern));
+    return Result;
+  }
----------------
I think you can do

  if (!HasWildcards)
    return {find(Pattern)};

================
Comment at: ELF/SymbolTable.h:88
@@ -87,2 +87,3 @@
   SymbolBody *find(StringRef Name);
+  std::vector<SymbolBody *> findAll(StringRef Prefix);
   void wrap(StringRef Name);
----------------
s/Prefix/Pattern/


http://reviews.llvm.org/D21732