[PATCH] D21775: [InstCombine] Simplify and correct folding fcmps with the same children

[Tim Shen via llvm-commits]

timshen added a comment.

> 1. Create all N tests in the existing test files. I don't think there's much value in the commuted variants, so this would actually be N = 16*17 = 272 I think.

> 2. Run the script to generate the CHECK lines.

> 3. Commit these test changes to trunk.


I prefer not to commit this to the trunk, but only locally, since @t6 in or-fcmp.ll is testing an actual existing bug (sorry for not put that explicitly). It'd be weird to check-in something that is known wrong, and make them pass later.

How about I compare the auto-generated CHECKs and post the functional differences here in the comments, we inspect it, and then check-in the patch with all N tests (with correct CHECKs) together?


http://reviews.llvm.org/D21775