[PATCH] D21813: ARM: Fix ARMSubtarget for WOA

Martell Malone via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 15:49:24 PDT 2016


martell added a comment.

In http://reviews.llvm.org/D21813#469255, @rengolin wrote:

> Have you run all the tests on Windows (check-all)?


No but I will do.
More changes need to go into Signals.inc to properly print everything out as was intended on ARM.
I just submitted the patch initially to get feedback to see if the change was accurate


================
Comment at: lib/Support/Windows/Signals.inc:535
@@ -532,1 +534,3 @@
+  StackFrame.AddrStack.Offset = Context.Sp;
+  StackFrame.AddrFrame.Offset = Context.Lr;
 #endif
----------------
rengolin wrote:
> Shouldn't this be Fp?
Yes it should


http://reviews.llvm.org/D21813





More information about the llvm-commits mailing list