[PATCH] D21775: [InstCombine] Simplify and correct folding fcmps with the same children

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 15:16:25 PDT 2016


timshen added a comment.

> If there's nothing obvious, we might as well just copy/paste the entire set into the existing regression test files.


I guess I missed a bit of context. Copy from where? By saying regression test files do you mean test/Transforms/InstCombine/and-fcmp.ll and test/Transforms/InstCombine/or-fcmp.ll?

Besides, auto-generate the CHECKs (assertions?) won't help with the LLVM code coverage, will it? If not, should we generate all 512 (regardless of the commutations) cases, since it's not that many? But then we have to test the generator... :P.


http://reviews.llvm.org/D21775





More information about the llvm-commits mailing list