[PATCH] D21781: [ELF] Warn for duplicate symbols in version scripts instead of erroring out

[Rafael Espíndola via llvm-commits]

On 28 June 2016 at 16:53, Davide Italiano <davide at freebsd.org> wrote:
> On Tue, Jun 28, 2016 at 1:50 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>>> I share your feelings, Rafael, at least partly. I always try to err on
>>> the side of safety (which in this case would mean emitting an error).
>>> In this case tho, I'm not entirely sure it's an option. I may miss
>>> something, so, here's my question: how do you plan to deal with
>>> downstream consumers? I agree people abused of this feature because in
>>> the past there was no error handling/checking. But this is the world
>>> we (have to) live in, and it's (IMHO) not entirely reasonable asking
>>> people to change their version scripts which before worked just fine.
>>
>>
>> Depends how common that abuse is. If we have a compelling reason for
>> them to use lld and the fix is simple, I think we should try fixing
>> downstream. So far it was just openoffice, right?
>>
>
> So, here's my proposition. I'll leave this commit in as is (i.e. I
> won't revert it for now), but I'll schedule a package run with ~23k
> packages on FreeBSD or Linux to see what this feature breaks. After we
> get the number we can decide. Realistically I won't be able to get to
> it before mid-next week. How does that sound to you?

Sure, sounds reasonable. Do note that we currently give a different
answer than bfd or gold in cases this error would fire.

Thanks,
Rafael