[PATCH] D21781: [ELF] Warn for duplicate symbols in version scripts instead of erroring out

Tue Jun 28 13:59:35 PDT 2016

emaste added a subscriber: emaste.
emaste added a comment.

In http://reviews.llvm.org/D21781#468584, @ruiu wrote:

> LGTM. If it's still too verbose, we should just remove this code.

I definitely don't want to see the warning removed altogether (and have a slight preference for seeing this become an error again eventually).

FreeBSD's libcxxrt version map has had a copy-and-paste error for 2.5 years (since it was introduced) resulting in missing exported symbols: it had duplicated _ZTIPDn entries, instead of _ZTIPDn and _ZTSPDn. The mistake went unnoticed until I tried building with lld and encountered the duplicate symbol error from lld.

https://reviews.freebsd.org/D7011

Repository:
  rL LLVM

http://reviews.llvm.org/D21781