[PATCH] D21781: [ELF] Warn for duplicate symbols in version scripts instead of erroring out

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 05:30:00 PDT 2016


I really think this should be an error. If we need a hack for now it
should be warning, but we should have an open bug on making this an
error again.

Both gold and bfd put the symbol just in the first version. We put it
just in the last version. Both are really confusing.

I will open a bug on making this a error again.

Cheers,
Rafael


On 28 June 2016 at 02:04, George Rimar <grimar at accesssoftek.com> wrote:
> grimar added a comment.
>
> In http://reviews.llvm.org/D21781#468631, @ruiu wrote:
>
>> It may be a misuse of a feature, but is it really an error?
>
>
> Well, listing the same symbol under one version does not seem to be a error for me,
> but listing the same symbol under different versions at least worth a warning as
> it is possible that linker override one and that is confusing.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D21781
>
>
>


More information about the llvm-commits mailing list