[PATCH] D21788: [ELF] - Remove Config->ZDefs flag.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 28 04:42:42 PDT 2016
ruiu added inline comments.
================
Comment at: ELF/Driver.cpp:366
@@ -365,2 +365,3 @@
+ Config->NoUndefined |= hasZOption(Args, "defs");
Config->ZCombreloc = !hasZOption(Args, "nocombreloc");
----------------
grimar wrote:
> ruiu wrote:
> > Config->NoUndefined = Args.hasArg(OPT_no_undefined) || hasZOption(Args, "defs")
> >
> > would be better.
> Ok. I wanted to leave -z group along, but that also works.
I understand, but `|=` seems too subtle.
http://reviews.llvm.org/D21788
More information about the llvm-commits
mailing list