[PATCH] D21782: [CodeView] Implement support for bitfields in LLVM

[Amjad Aboud via llvm-commits]

aaboud added a comment.

Looks good.
I suggest to add a test that covers more cases, see below.
Also, need to apply changes to dwarf implementation (I think it does not cover the below case correctly today).

I am adding David Blaikie as a reviewer.


================
Comment at: test/DebugInfo/COFF/bitfields.ll:3
@@ +2,3 @@
+
+; C++ source to regenerate:
+; $ cat t.cpp
----------------
How about having full test of bitfield. This test contains only the last issue.
How about this one:

```
#pragma pack(1)
struct S1 {
  char x1[2];
  char x2;
  int y : 23;
  int z : 23;
  int w : 2;
  struct { char c; short s; } v;
  short u : 3;
} s1;

#pragma pack(1)
struct S2 {
  char : 0;
  int y : 1;
} s2;

#pragma pack(1)
struct S3 {
  char : 8;
  short : 8;
  short x : 8;
} s3;
```

Or at least parts of it.


http://reviews.llvm.org/D21782