[PATCH] D21276: [AArch64]Make getDefaultExtensions to return exactly what we want.

[jojo.ma via llvm-commits]

jojo added a comment.

Dear Eric,

Thank you so much for your carefully review.This prompted me to look into this part more carefully.

Now the real root cause of the problem has surfaced:

  Actually this is a problem of the array bounds. The reason why 
  it runs well on my local machine(using gcc) but broke some specific buildbots(using clang) is that 
  there is a incorrect indexing problem in the targetparser, which cause we use a   
  value  beyond the bounds of the array (AArch64ARCHNames[ID].ArchBaseExtensions). It is zero in
  gcc but a big and meaningless value in clang(I guess it's a different memory initialization).
  I thought it is because whether using C++11 or not,now that it's not. Actually it is not need to OR 
  the ArchBaseExtensions for AArch64TargetParser tables. So we should remove it.

And I am writing testcases for {ARM|AArch64}targetparser,so we will have no worries.
Now the part for AArch64TargetParser is done.All the changes for the problem correcting and
testcases is in revision D21785 <http://reviews.llvm.org/D21785>.
Welcome your comments and any nitpick.


Repository:
  rL LLVM

http://reviews.llvm.org/D21276