[PATCH] D21776: MSSA Walker Pre-refactor

[Daniel Berlin via llvm-commits]

dberlin added a subscriber: dberlin.

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:551
@@ -550,3 +605,1 @@
-}
-
 /// \brief Returns true if \p Replacer dominates \p Replacee .
----------------
I see you removed this - this is a utility being used as part of updating for another pass i haven't submitted yet.



================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:856
@@ -805,1 +855,3 @@
+  // A node dominates itself, and liveOnEntry dominates everything.
+  if (Dominatee == Dominator || isLiveOnEntryDef(Dominator))
     return true;
----------------
This makes no sense unless the block we are talking about is the entry block.
Otherwise, how are they in the same block?

(if it is the entry block, the loop below will give the correct answer, no?)


http://reviews.llvm.org/D21776