[llvm] r273974 - [PM] Normalize FIXMEs for missing PreserveCFG to have the same wording.

[Michael Kuperstein via llvm-commits]

Author: mkuper
Date: Mon Jun 27 19:54:12 2016
New Revision: 273974

URL: http://llvm.org/viewvc/llvm-project?rev=273974&view=rev
Log:
[PM] Normalize FIXMEs for missing PreserveCFG to have the same wording.

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp
    llvm/trunk/lib/Transforms/Scalar/ADCE.cpp
    llvm/trunk/lib/Transforms/Scalar/BDCE.cpp
    llvm/trunk/lib/Transforms/Scalar/Float2Int.cpp
    llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
    llvm/trunk/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
    llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
    llvm/trunk/lib/Transforms/Utils/LCSSA.cpp
    llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp

Modified: llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp Mon Jun 27 19:54:12 2016
@@ -3111,7 +3111,7 @@ PreservedAnalyses InstCombinePass::run(F
     return PreservedAnalyses::all();
 
   // Mark all the analyses that instcombine updates as preserved.
-  // FIXME: Need a way to preserve CFG analyses here!
+  // FIXME: This should also 'preserve the CFG'.
   PreservedAnalyses PA;
   PA.preserve<DominatorTreeAnalysis>();
   return PA;

Modified: llvm/trunk/lib/Transforms/Scalar/ADCE.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/ADCE.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/ADCE.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/ADCE.cpp Mon Jun 27 19:54:12 2016
@@ -149,8 +149,7 @@ PreservedAnalyses ADCEPass::run(Function
   if (!aggressiveDCE(F))
     return PreservedAnalyses::all();
 
-  // FIXME: ADCE should also 'preserve the CFG'.
-  // The new pass manager has currently no way to do it.
+  // FIXME: This should also 'preserve the CFG'.
   auto PA = PreservedAnalyses();
   PA.preserve<GlobalsAA>();
   return PA;

Modified: llvm/trunk/lib/Transforms/Scalar/BDCE.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/BDCE.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/BDCE.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/BDCE.cpp Mon Jun 27 19:54:12 2016
@@ -74,8 +74,7 @@ PreservedAnalyses BDCEPass::run(Function
   if (!bitTrackingDCE(F, DB))
     return PreservedAnalyses::all();
 
-  // FIXME: BDCE should also 'preserve the CFG'.
-  // The new pass manager has currently no way to do it.
+  // FIXME: This should also 'preserve the CFG'.
   auto PA = PreservedAnalyses();
   PA.preserve<GlobalsAA>();
   return PA;

Modified: llvm/trunk/lib/Transforms/Scalar/Float2Int.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/Float2Int.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/Float2Int.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/Float2Int.cpp Mon Jun 27 19:54:12 2016
@@ -532,7 +532,7 @@ PreservedAnalyses Float2IntPass::run(Fun
   if (!runImpl(F))
     return PreservedAnalyses::all();
   else {
-    //FIXME: setPreservesCFG is not currently supported in the new PM.
+    // FIXME: This should also 'preserve the CFG'.
     PreservedAnalyses PA;
     PA.preserve<GlobalsAA>();
     return PA;

Modified: llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp Mon Jun 27 19:54:12 2016
@@ -2233,8 +2233,7 @@ PreservedAnalyses IndVarSimplifyPass::ru
   if (!IVS.run(&L))
     return PreservedAnalyses::all();
 
-  // FIXME: once we have an equivalent of AU.setPreservesCFG() in the
-  // new pass manager, we should use that here.
+  // FIXME: This should also 'preserve the CFG'.
   return getLoopPassPreservedAnalyses();
 }
 

Modified: llvm/trunk/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp Mon Jun 27 19:54:12 2016
@@ -595,8 +595,7 @@ MergedLoadStoreMotionPass::run(Function
   if (!Impl.run(F, MD, AA))
     return PreservedAnalyses::all();
 
-  // FIXME: This pass should also 'preserve the CFG'.
-  // The new pass manager has currently no way to do it.
+  // FIXME: This should also 'preserve the CFG'.
   PreservedAnalyses PA;
   PA.preserve<GlobalsAA>();
   PA.preserve<MemoryDependenceAnalysis>();

Modified: llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp Mon Jun 27 19:54:12 2016
@@ -2226,8 +2226,7 @@ PreservedAnalyses ReassociatePass::run(F
   ValueRankMap.clear();
 
   if (MadeChange) {
-    // FIXME: Reassociate should also 'preserve the CFG'.
-    // The new pass manager has currently no way to do it.
+    // FIXME: This should also 'preserve the CFG'.
     auto PA = PreservedAnalyses();
     PA.preserve<GlobalsAA>();
     return PA;

Modified: llvm/trunk/lib/Transforms/Utils/LCSSA.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LCSSA.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/LCSSA.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/LCSSA.cpp Mon Jun 27 19:54:12 2016
@@ -340,8 +340,7 @@ PreservedAnalyses LCSSAPass::run(Functio
   if (!formLCSSAOnAllLoops(&LI, DT, SE))
     return PreservedAnalyses::all();
 
-  // FIXME: There is no setPreservesCFG in the new PM. When that becomes
-  // available, it should be used here.
+  // FIXME: This should also 'preserve the CFG'.
   PreservedAnalyses PA;
   PA.preserve<BasicAA>();
   PA.preserve<GlobalsAA>();

Modified: llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp?rev=273974&r1=273973&r2=273974&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/Mem2Reg.cpp Mon Jun 27 19:54:12 2016
@@ -59,11 +59,7 @@ PreservedAnalyses PromotePass::run(Funct
   if (!promoteMemoryToRegister(F, DT, AC))
     return PreservedAnalyses::all();
 
-  // FIXME: This pass should preserve the CFG.
-  // There's currently no way to do it in the new PM.
-  // In the old PM this pass preserved a fair amount of "orthogonal"
-  // transformation passes. This concept has no sense in the new PM,
-  // therefore we don't preserve them here.
+  // FIXME: This should also 'preserve the CFG'.
   return PreservedAnalyses::none();
 }