[PATCH] D19681: builtins: use -fPIC if supported
Brian Silverman via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 27 11:20:31 PDT 2016
brian added a comment.
@compnerd: It looks like you're a committer, so you can you commit this?
Thanks!
================
Comment at: lib/builtins/CMakeLists.txt:378
@@ -377,2 +377,3 @@
append_string_if(COMPILER_RT_HAS_STD_C99_FLAG -std=c99 maybe_stdc99)
+ append_string_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC maybe_fpic)
----------------
compnerd wrote:
> This needs to be more target specific. Not all targets may support this flag.
I think cmake/builtin-config-ix.cmake checks if the target supports the flag when setting COMPILER_RT_HAS_FPIC_FLAG. Also, it's set the same way COMPILER_RT_HAS_STD_C99_FLAG is, which I doubt all targets support either. Is there something wrong with that approach?
http://reviews.llvm.org/D19681
More information about the llvm-commits
mailing list