[PATCH] D21736: [InstrProfiling] Mark __llvm_profile_instrument_target last parameter as i32 zeroext if appropriate.

[Xinliang David Li via llvm-commits]

On Mon, Jun 27, 2016 at 9:38 AM, Marcin Kościelnicki <koriakin at 0x04.net>
wrote:

> koriakin added a comment.
>
> In http://reviews.llvm.org/D21736#467986, @davidxl wrote:
>
> > One nit. Can you save TLI pointer in InstProfiling instead of passing it
> around?
>
>
> Save where? I thought run is not supposed to modify the Pass object, and I
> don't have TLI before that.
>

In InstrProfiling::run method -- see that Module is also saved there.

Passing one analysis around may not be a big problem, but I think we should
make the interface consistent here.

David


>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D21736
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160627/7af1d85b/attachment.html>