[llvm] r273857 - [sparc] Simplify slow and verbose string matching code to startswith_lower.

[Benjamin Kramer via llvm-commits]

Author: d0k
Date: Mon Jun 27 04:38:56 2016
New Revision: 273857

URL: http://llvm.org/viewvc/llvm-project?rev=273857&view=rev
Log:
[sparc] Simplify slow and verbose string matching code to startswith_lower.

No functionality change intended, found by cppcheck. PR28274.

Modified:
    llvm/trunk/lib/Target/Sparc/LeonPasses.cpp

Modified: llvm/trunk/lib/Target/Sparc/LeonPasses.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/LeonPasses.cpp?rev=273857&r1=273856&r2=273857&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Sparc/LeonPasses.cpp (original)
+++ llvm/trunk/lib/Target/Sparc/LeonPasses.cpp Mon Jun 27 04:38:56 2016
@@ -169,10 +169,9 @@ bool FixFSMULD::runOnMachineFunction(Mac
         Reg3Index = MI.getOperand(2).getReg();
       }
       else if (MI.isInlineAsm()) {
-        std::string AsmString (MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
-        std::string FMULSOpCoode ("fsmuld");
-        std::transform(AsmString.begin(), AsmString.end(), AsmString.begin(), ::tolower);
-        if (AsmString.find(FMULSOpCoode) == 0) { // this is an inline FSMULD instruction
+        StringRef AsmString(
+            MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
+        if (AsmString.startswith_lower("fsmuld")) {
           //errs() << "Detected InlineAsm FSMULD\n";
 
           unsigned StartOp = InlineAsm::MIOp_FirstOperand;
@@ -281,10 +280,9 @@ bool ReplaceFMULS::runOnMachineFunction(
         Reg3Index = MI.getOperand(2).getReg();
       }
       else if (MI.isInlineAsm()) {
-        std::string AsmString (MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
-        std::string FMULSOpCoode ("fmuls");
-        std::transform(AsmString.begin(), AsmString.end(), AsmString.begin(), ::tolower);
-        if (AsmString.find(FMULSOpCoode) == 0) { // this is an inline FMULS instruction
+        StringRef AsmString(
+            MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
+        if (AsmString.startswith_lower("fmuls")) {
           //errs() << "Detected InlineAsm FMULS\n";
 
           unsigned StartOp = InlineAsm::MIOp_FirstOperand;
@@ -377,15 +375,12 @@ bool FixAllFDIVSQRT::runOnMachineFunctio
       unsigned Opcode = MI.getOpcode();
 
       if (MI.isInlineAsm()) {
-        std::string AsmString (MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
-        std::string FSQRTDOpCode ("fsqrtd");
-        std::string FDIVDOpCode ("fdivd");
-        std::transform(AsmString.begin(), AsmString.end(), AsmString.begin(), ::tolower);
-        if (AsmString.find(FSQRTDOpCode) == 0) { // this is an inline fsqrts instruction
+        StringRef AsmString(
+            MI.getOperand(InlineAsm::MIOp_AsmString).getSymbolName());
+        if (AsmString.startswith_lower("fsqrtd")) {
           //errs() << "Detected InlineAsm FSQRTD\n";
           Opcode = SP::FSQRTD;
-        }
-        else if (AsmString.find(FDIVDOpCode) == 0) { // this is an inline fsqrts instruction
+        } else if (AsmString.startswith_lower("fdivd")) {
           //errs() << "Detected InlineAsm FDIVD\n";
           Opcode = SP::FDIVD;
         }