[PATCH] D21588: [asan] Relax a flaky invalid-pointer-pairs test

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 26 12:50:03 PDT 2016


kubabrecka added a comment.

In http://reviews.llvm.org/D21588#464443, @filcab wrote:

> Do you have any idea why we get this difference? Would be nice to know, and possibly to account for.


This is due to `INLINE` on CheckForInvalidPointerPair.  The function doesn’t get inlined in Debug builds, and the inlining is not even guaranteed for Release builds.  If we never need the `__sanitizer_ptr_cmp` frame, we should use `ALWAYS_INLINE`, which seems to resolve the issue as well.


Repository:
  rL LLVM

http://reviews.llvm.org/D21588





More information about the llvm-commits mailing list