[PATCH] D21668: [ARM] Fix cost computation for constant hoisting

[Renato Golin via llvm-commits]

rengolin added a comment.

Hi Weiming,

The code makes sense, but the test is not clear as to what it's all about or what's the expected output, which will make it very hard for people to follow up when it breaks for other reasons.

Can you add a comment to the test explaining what's this is about and what's the expected behaviour?

cheers,
--renato


================
Comment at: test/Transforms/ConstantHoisting/ARM/bad-cases.ll:107
@@ +106,3 @@
+  %cast0 = trunc i96 %lshr0 to i32
+;lshr1 = lshr i96 %load1, 32
+  %lshr1 = lshr i96 %load1, 32
----------------
Was this line supposed to be a CHECK?


http://reviews.llvm.org/D21668