[PATCH] D21681: [ELF] - Implemented support of default/non-default symbols versions

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:166
@@ -165,1 +165,3 @@
 
+static void setupVersionAttributes(Symbol *Sym, StringRef Name) {
+  size_t VersionBegin = Name.find('@');
----------------
You can make this function side-effect-free.

  static uint16_t getVersionId(Symbol *Sym, StringRef Name)

which returns a version ID. Then use it in insert() like this.

  Sym->VersionId = getVersionId(Sym, Name);


http://reviews.llvm.org/D21681