[PATCH] D21725: [LoopUnswitch] Unswitch on conditions feeding into guards
Sanjoy Das via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 25 01:40:18 PDT 2016
sanjoy added inline comments.
================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:532
@@ +531,3 @@
+
+ SmallVector<AssertingVH<IntrinsicInst>, 4> Guards;
+
----------------
majnemer wrote:
> Is it safe to make this an AssertingVH? Could unswitching one guard lead to another guard getting cloned while the original gets erased?
Good point. Added a test case and changed to keep raw pointers for now.
http://reviews.llvm.org/D21725
More information about the llvm-commits
mailing list