[llvm] r273763 - [LoopUnswitch] Avoid exponential behavior

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 21:51:11 PDT 2016


Hi Justin,

On Fri, Jun 24, 2016 at 9:44 PM, Justin Bogner <mail at justinbogner.com> wrote:
> Sanjoy Das via llvm-commits <llvm-commits at lists.llvm.org> writes:
>> Author: sanjoy
>> Date: Fri Jun 24 20:14:19 2016
>> New Revision: 273763
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=273763&view=rev
>> Log:
>> [LoopUnswitch] Avoid exponential behavior
>>
>> Summary: (No semantic change intended).
>>
>> Reviewers: majnemer, bogner, mzolotukhin
>
> I guess this is a phab thing? This line is very misleading and really
> shouldn't be included in commit messages.

This is an arcanist thing (it amends the git commit message).  I
wouldn't call it very misleading as much as cluttering.  I just ignore
it, knowing that it is useless (I suspect most others do the same).

>> Subscribers: mcrosier, llvm-commits, mzolotukhin
>
> Similarly, this isn't very helpful.
>
> I've filed llvm.org/PR28300 about the problem, but if there's an obvious
> way to fix this on your end when committing I would appreciate it.

I'll take a look to see if I can teach arcanist to not add these.

-- Sanjoy


More information about the llvm-commits mailing list