[PATCH] D21711: [yaml2obj] Remove --format option in favor of YAML tags

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 19:22:42 PDT 2016


compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
compnerd added a comment.
This revision is now accepted and ready to land.

Nice!  I think it would be a good idea to add a few tests.  Basically, feed it a yaml document and ensure that the format detection happens correctly.


================
Comment at: tools/yaml2obj/yaml2macho.cpp:450
@@ -449,3 +449,3 @@
   }
   if (auto Err = writeFatHeader(OS))
     return Err;
----------------
Not your fault, but its hard to see that the code here is switching between a fat macho or a sliced/lipo'ed/thin one.


http://reviews.llvm.org/D21711





More information about the llvm-commits mailing list