[PATCH] D21699: [PM] Port PartialInlining to new PM
Easwaran Raman via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 24 17:17:17 PDT 2016
eraman marked an inline comment as done.
eraman added a comment.
In http://reviews.llvm.org/D21699#466863, @davide wrote:
> There's always the tradeoff between:
>
> - using an `Impl` object as you did
> - staticizing the member variables in order to share code them between old and new PM.
>
> I'd prefer 2) in this case, because there's only one member variable, but I have no strong opinions about that. With that in mind, I don't think it's worth rewriting this patch to use the other approach, as the boilerplate introduced is very little.
I don't have a strong opinion. As you say, there is very little bolierplate and I'll keep this version.
http://reviews.llvm.org/D21699
More information about the llvm-commits
mailing list