[PATCH] D21704: [PM] Port float2int to the new pass manager

[David Li via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/Transforms/Scalar/Float2Int.cpp:537
@@ +536,3 @@
+PreservedAnalyses Float2IntPass::run(Function &F, FunctionAnalysisManager &) {
+  //FIXME: skipFunction is not currently supported in the new PM.
+  if (!Impl.runImpl(F))
----------------
This is a good point. Is there a bug tracking this missing functionality?

================
Comment at: lib/Transforms/Scalar/Float2Int.cpp:541
@@ +540,3 @@
+  else {
+    //FIXME: setPreservesCFG is not currently supported in the new PM.
+    PreservedAnalyses PA;
----------------
same here.


http://reviews.llvm.org/D21704