[PATCH] D21699: [PM] Port PartialInlining to new PM

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 15:02:50 PDT 2016


davide added a comment.

There's always the tradeoff between:

- using an `Impl` object as you did
- staticizing the member variables in order to share code them between old and new PM.

I'd prefer 2) in this case, because there's only one member variable, but I have no strong opinions about that.
With that in mind, I don't think it's worth rewriting this patch to use the other approach, as the boilerplate introduced is very little.


http://reviews.llvm.org/D21699





More information about the llvm-commits mailing list