[PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

Hubert Tong via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 14:38:49 PDT 2016


hubert.reinterpretcast added inline comments.

================
Comment at: include/llvm/Support/TrailingObjects.h:363
@@ +362,3 @@
+    template <size_t... Counts> struct with_counts {
+      enum { Size = totalSizeToAlloc<Tys...>(Counts...) };
+      typedef llvm::AlignedCharArray<
----------------
@aaron.ballman; my attempt with an online MSVC compiler is that this works around the compiler error. Can you confirm that this patch is safe for your MSVC build?

Also, do you feel strongly about making `Size` private?


http://reviews.llvm.org/D19770





More information about the llvm-commits mailing list