[PATCH] D21701: [AMDGPU] Fix warning

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 14:28:41 PDT 2016


arsenm added a comment.

Where are you seeing this warning? It's switching over all values of the enum so I see the warning for that if I add the default


================
Comment at: lib/Target/AMDGPU/AMDGPUInstrInfo.cpp:147-149
@@ -146,2 +146,5 @@
   switch (ST.getGeneration()) {
+  default:
+    llvm_unreachable("invalid generation");
+  // fall through
   case AMDGPUSubtarget::SOUTHERN_ISLANDS:
----------------
Fall through comment doesn't make sense after unreachable


http://reviews.llvm.org/D21701





More information about the llvm-commits mailing list