[PATCH] D21251: [TTI] The cost model should not assume illegal vector casts get completely scalarized
Demikhovsky, Elena via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 24 10:56:40 PDT 2016
The cost numbers in the tests are good enough. I checked them for all X86 targets, especially for AVX-512 which has unsigned conversions and i64 type.
I also changed SSE/AVX/AVX-512 tables there, may be you’ll want to take a look.
- Elena
From: Michael Kuperstein [mailto:mkuper at google.com]
Sent: Friday, June 24, 2016 01:05
To: Demikhovsky, Elena <elena.demikhovsky at intel.com>
Cc: reviews+D21251+public+7bb3c686dff8f34a at reviews.llvm.org; silviu.baranga at arm.com; hfinkel at anl.gov; james.molloy at arm.com; thomas.stellard at amd.com; llvm-dev at redking.me.uk; Matthew.Arsenault at amd.com; llvm-commits at lists.llvm.org; amara.emerson at arm.com
Subject: Re: [PATCH] D21251: [TTI] The cost model should not assume illegal vector casts get completely scalarized
Ah, it's a shame I missed D15604, would have saved me the trouble of figuring out getTypeLegalizationCost() is mis-named.
Anyway, I think this patch should more or less take care of the type legalization aspect of D15604.
Regarding the changes D15604 made in the cost table - was there a reason you abandoned them? Or are they independently good?
On Thu, Jun 23, 2016 at 2:55 PM, Demikhovsky, Elena <elena.demikhovsky at intel.com<mailto:elena.demikhovsky at intel.com>> wrote:
>If you don't mind, I'll add the test as a separate patch - we don't only want
>this specific test, we need tests for a bunch of sexts/zexts, like ARM has.
>
[Demikhovsky, Elena] yes, you can add tests later. You can look at this revision as a test reference for X86
http://reviews.llvm.org/D15604
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160624/77879da9/attachment.html>
More information about the llvm-commits
mailing list