[PATCH] D21640: [ELF] - Fix incorrect logic in VersionScriptParser::parseVersion()
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 24 01:15:42 PDT 2016
grimar updated this revision to Diff 61762.
grimar added a comment.
- Addressed review comments.
http://reviews.llvm.org/D21640
Files:
ELF/SymbolListFile.cpp
test/ELF/verdef-dependency.s
Index: test/ELF/verdef-dependency.s
===================================================================
--- test/ELF/verdef-dependency.s
+++ test/ELF/verdef-dependency.s
@@ -8,7 +8,7 @@
# RUN: local: *; }LIBSAMPLE_1.0; \
# RUN: LIBSAMPLE_3.0{ \
# RUN: global: c; \
-# RUN: local: *; }LIBSAMPLE_2.0;" > %t.script
+# RUN: }LIBSAMPLE_2.0;" > %t.script
# RUN: ld.lld --version-script %t.script -shared -soname shared %t.o -o %t.so
# RUN: llvm-readobj -V -dyn-symbols %t.so | FileCheck --check-prefix=DSO %s
Index: ELF/SymbolListFile.cpp
===================================================================
--- ELF/SymbolListFile.cpp
+++ ELF/SymbolListFile.cpp
@@ -90,7 +90,7 @@
}
if (peek() == "local:")
parseLocal();
- else
+ else if (peek() != "}")
parseVersionSymbols(Version);
expect("}");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21640.61762.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160624/ea4b0c7b/attachment.bin>
More information about the llvm-commits
mailing list