[PATCH] D21628: [ELF] Allow --reproduce to be specified as an env variable

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.[[ URL | name ]]


================
Comment at: ELF/Driver.cpp:239
@@ +238,3 @@
+static const char *getReproduceOption(opt::InputArgList &Args) {
+  const char *ReproducePath = nullptr;
+  if (Args.hasArg(OPT_reproduce))
----------------
This variable is dead.

================
Comment at: ELF/Driver.cpp:264
@@ -255,3 +263,3 @@
 
-  if (auto *Arg = Args.getLastArg(OPT_reproduce)) {
+  if (const char *ReproducePath = getReproduceOption(Args)) {
     // Note that --reproduce is a debug option so you can ignore it
----------------
This line has two occurrence of `Reproduce`. This is too much. I'd name just `Path`.


http://reviews.llvm.org/D21628