[PATCH] D21645: [CFLAA] Propagate StratifiedAttrs from callee to caller

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 18:02:41 PDT 2016


grievejia added inline comments.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:644-645
@@ -602,4 +643,4 @@
 
-    GetEdgesVisitor(Analysis, TLI, Graph, ExternalValues, EscapedValues,
-                    InterprocEdges)
+    GetEdgesVisitor(Analysis, TLI, Graph, ReturnedValues, ExternalValues,
+                    EscapedValues, InterprocEdges, InterprocAttrs)
         .visit(Inst);
----------------
george.burgess.iv wrote:
> Sure -- why doesn't CFLGraphBuilder have a member of type `GetEdgesVisitor`, instead of constructing it in-place here? It doesn't really matter either way, I'm just wondering if there's a reason, since all we're basically doing is loading it up with member variables and calling `visit`.
But even if GetEdgeVisitor becomes a member of CFLGraphBuilder, we still have to load the member up and call visit, no?


http://reviews.llvm.org/D21645





More information about the llvm-commits mailing list