[PATCH] D21656: [compiler-rt] Include <dlfcn.h> unconditionally

Julien Ramseier via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 11:51:06 PDT 2016


elram created this revision.
elram added a reviewer: aizatsky.
elram added a subscriber: llvm-commits.
Herald added subscribers: kubabrecka, srhines, danalbert, tberghammer.

Not sure why this was ifdef-ed in the first place.
All other sources include <dlfcn.h> directly without checking the platform.

This fixes a build issue with musl-libc.

http://reviews.llvm.org/D21656

Files:
  lib/sanitizer_common/sanitizer_linux_libcdep.cc

Index: lib/sanitizer_common/sanitizer_linux_libcdep.cc
===================================================================
--- lib/sanitizer_common/sanitizer_linux_libcdep.cc
+++ lib/sanitizer_common/sanitizer_linux_libcdep.cc
@@ -26,10 +26,7 @@
 #include "sanitizer_procmaps.h"
 #include "sanitizer_stacktrace.h"
 
-#if SANITIZER_ANDROID || SANITIZER_FREEBSD
 #include <dlfcn.h>  // for dlsym()
-#endif
-
 #include <link.h>
 #include <pthread.h>
 #include <signal.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21656.61705.patch
Type: text/x-patch
Size: 468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160623/21be75ee/attachment.bin>


More information about the llvm-commits mailing list