[llvm-dev] [patch] fix Thumb text sections' flags under COFF/Windows
Renato Golin via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 23 14:12:39 PDT 2016
On 23 June 2016 at 20:49, Adrien Guinet via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> I had no answer from llvm-dev for this patch below, I'm reposting it
> here 'cause I think I got the wrong mailing list? (according to
> http://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch
> where I forgot the keyword *commit* mailing-list).
Hi Adrien,
Sorry, I completely missed your patch. Would you mind submitting your
patch to our code review tool?
http://llvm.org/docs/Phabricator.html
Just signup and upload the patch via the web interface would be fine.
In the field "Reviewers", please add me (rengolin) and Saleem
(compnerd) and we'll have a look.
Just a few tips:
* If you have more than one bug fix, please submit more than one
patch. It's perfectly fine to submit multiple small patches, we
actually prefer that.
* Give meaningful descriptions, but you don't need to describe the
code itself. If the code is not obvious at review time, it won't be
obvious later. Comments help, obviously! :)
* When sending a patch, copying more people than just llvm-commits
help a lot. Search on the list for people working on similar areas or
look at CODE_OWNERS.TXT for maintainers.
Your original email was pretty good, feel free to repeat that on the
review descriptions (minus the code).
Thanks!
--renato
More information about the llvm-commits
mailing list