[PATCH] D21614: [codeview] Add DISubprogram::ThisAdjustment

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 11:29:21 PDT 2016


rnk added a comment.

In http://reviews.llvm.org/D21614#465188, @rnk wrote:

> In http://reviews.llvm.org/D21614#465134, @aprantl wrote:
>
> > Is this something that maybe is only needed on function definitions versus declarations?
> >  We're planning to split these up anyway, maybe we can make this field optional after/during the split?
>
>
> Unfortunately, it would need to live on the declaration, because we need it when emitting the class member list.


This is actually like the virtualindex, which only lives on the declaration and not the definition. So, shall we go ahead?


http://reviews.llvm.org/D21614





More information about the llvm-commits mailing list