[PATCH] D21650: DAGCombiner: Don't narrow volatile vector loads + extract

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 10:38:42 PDT 2016


ab added a subscriber: ab.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12465-12467
@@ -12461,5 +12464,5 @@
     SDValue Index = N->getOperand(1);
     if (LoadSDNode *OrigLoad = dyn_cast<LoadSDNode>(InVec))
       return ReplaceExtractVectorEltOfLoadWithNarrowedLoad(N, VT, Index,
                                                            OrigLoad);
   }
----------------
The other callsite checks isVolatile() already.  Do the same here and assert in ReplaceExtractVectorEltOfLoadWithNarrowedLoad?

Or remove the other check; but we might as well make them consistent.


http://reviews.llvm.org/D21650





More information about the llvm-commits mailing list