[PATCH] D21643: Default to using the Unicode version of Win32 APIs

[Aaron Ballman via llvm-commits]

aaron.ballman added a comment.

In http://reviews.llvm.org/D21643#465583, @llvm-commits wrote:

> Should we add overloads of the UTF8 conversion functions that accept
>  wstrings?


I think we should eventually consider cleaning up our Unicode APIs because they're kind of all over the place. For instance, WindowsSupport.h has a different set of APIs for handling Unicode conversions that compete with the ones exposed by ConvertUTF.h.

> In line with what rnk said, I'm curious about the implications of simply

>  #undef'ing all the non A/W versions of functions so that you have to make

>  the choice explicit


I'm not certain I follow along. Are you suggesting we explicitly #undef something like RegQueryValueEx so that you must explicitly call RegQueryValueExW or RegQueryValueExA, as needed? That seems like something that will quickly get forgotten about and not really used.


http://reviews.llvm.org/D21643