[PATCH] D21630: [codeview] Emit retained types

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 08:25:32 PDT 2016


rnk added inline comments.

================
Comment at: test/DebugInfo/COFF/retained-types.ll:14
@@ +13,3 @@
+
+; CHECK: CodeViewTypes [
+; CHECK:   Section: .debug$T (6)
----------------
Can you cut the checks down to look for the two Struct records and wild card away all the type indices? All the other types are not relevant to the test. Something like:
  ; CHECK: Struct ({{.*}}) {
  ; CHECK-NEXT: ...

  ; CHECK: Struct ({{.*}}) {
  ; CHECK-NEXT: ...

I was thinking about changing our dumper output to print the name of the type on the first line of the record so that it plays better with FileCheck, something like:
  Struct A (0xNNNN) {
  ... }
  Pointer A* (0xNNNN) {
  ... }


http://reviews.llvm.org/D21630





More information about the llvm-commits mailing list