[PATCH] D21639: CachePruning: correct comment about file order. NFC

[Paweł Bylica via llvm-commits]

chfast created this revision.
chfast added a subscriber: llvm-commits.

Actually the list of cached files is sorted by file size, not by last accessed time. Also remove unused file access time param for a helper function.

http://reviews.llvm.org/D21639

Files:
  lib/Support/CachePruning.cpp

Index: lib/Support/CachePruning.cpp
===================================================================
--- lib/Support/CachePruning.cpp
+++ lib/Support/CachePruning.cpp
@@ -88,9 +88,9 @@
   std::set<std::pair<uint64_t, std::string>> FileSizes;
   uint64_t TotalSize = 0;
   // Helper to add a path to the set of files to consider for size-based
-  // pruning, sorted by last accessed time.
+  // pruning, sorted by size.
   auto AddToFileListForSizePruning =
-      [&](StringRef Path, sys::TimeValue FileAccessTime) {
+      [&](StringRef Path) {
         if (!ShouldComputeSize)
           return;
         TotalSize += FileStatus.getSize();
@@ -128,7 +128,7 @@
     }
 
     // Leave it here for now, but add it to the list of size-based pruning.
-    AddToFileListForSizePruning(File->path(), FileAccessTime);
+    AddToFileListForSizePruning(File->path());
   }
 
   // Prune for size now if needed


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21639.61657.patch
Type: text/x-patch
Size: 905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160623/3f49dd82/attachment-0001.bin>