[PATCH] D21503: [llvm-dwarfdump] - Teach dwarfdump to dump gdb-index section.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: include/llvm/DebugInfo/DWARF/DWARFContext.h:227
@@ -223,2 +226,3 @@
   virtual StringRef getTUIndexSection() = 0;
+  virtual StringRef getGdbIndexSection() = 0;
 
----------------
davide wrote:
> Still unsorted.
Fixed.

================
Comment at: include/llvm/DebugInfo/DWARF/DWARFContext.h:280
@@ -275,2 +279,3 @@
   StringRef TUIndexSection;
+  StringRef GdbIndexSection;
 
----------------
davide wrote:
> Still unsorted.
Fixed.

================
Comment at: include/llvm/DebugInfo/DWARF/DWARFContext.h:327
@@ -321,2 +326,3 @@
   StringRef getTUIndexSection() override { return TUIndexSection; }
+  StringRef getGdbIndexSection() override { return GdbIndexSection; }
 };
----------------
davide wrote:
> Still unsorted.
Fixed.

================
Comment at: tools/llvm-dwarfdump/llvm-dwarfdump.cpp:76
@@ -75,2 +75,3 @@
+        clEnumValN(DIDT_GdbIndex, "gdb_index", ".gdb_index"), clEnumValEnd));
 
 static void error(StringRef Filename, std::error_code EC) {
----------------
Also fixed here. Though in this place I would sort all options alphabetically probably. Without trying to group them.


http://reviews.llvm.org/D21503