[llvm] r273474 - [IRObjectFile] Propagate .weak attribute correctly for ASM symbols.

[Davide Italiano via llvm-commits]

On Wed, Jun 22, 2016 at 2:50 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Wed, Jun 22, 2016 at 1:48 PM, Davide Italiano via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: davide
>> Date: Wed Jun 22 15:48:15 2016
>> New Revision: 273474
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=273474&view=rev
>> Log:
>> [IRObjectFile] Propagate .weak attribute correctly for ASM symbols.
>>
>> PR: 28256
>> Differential Revision:  http://reviews.llvm.org/D21616
>>
>> Modified:
>>     llvm/trunk/lib/Object/IRObjectFile.cpp
>>     llvm/trunk/lib/Object/RecordStreamer.cpp
>>     llvm/trunk/lib/Object/RecordStreamer.h
>>     llvm/trunk/test/Object/X86/nm-bitcodeweak.test
>>
>> Modified: llvm/trunk/lib/Object/IRObjectFile.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/IRObjectFile.cpp?rev=273474&r1=273473&r2=273474&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Object/IRObjectFile.cpp (original)
>> +++ llvm/trunk/lib/Object/IRObjectFile.cpp Wed Jun 22 15:48:15 2016
>> @@ -116,6 +116,9 @@ void IRObjectFile::CollectAsmUndefinedRe
>>        Res |= BasicSymbolRef::SF_Undefined;
>>        Res |= BasicSymbolRef::SF_Global;
>>        break;
>> +    case RecordStreamer::GlobalWeak:
>> +      Res |= BasicSymbolRef::SF_Weak;
>> +      Res |= BasicSymbolRef::SF_Global;
>
>
> You probably want a `break` here to be a bit more defensive.
>

Sure, why not, it's also more consistent with what was there already.
r273519.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare