[PATCH] D21563: [PM] refactoring of LoopAccessInfo /NFC

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 15:38:19 PDT 2016


anemet accepted this revision.
anemet added a comment.

LGTM too with the change below.


================
Comment at: include/llvm/Analysis/LoopAccessAnalysis.h:617-623
@@ -616,9 +616,9 @@
 
   /// We need to check that all of the pointers in this list are disjoint
   /// at runtime.
-  RuntimePointerChecking PtrRtChecking;
+  std::unique_ptr<RuntimePointerChecking> PtrRtChecking;
 
   /// \brief the Memory Dependence Checker which can determine the
   /// loop-independent and loop-carried dependences between memory accesses.
-  MemoryDepChecker DepChecker;
+  std::unique_ptr<MemoryDepChecker> DepChecker;
 
----------------
Please add a comment saying that these are pointers to facilitate the move ctor.


http://reviews.llvm.org/D21563





More information about the llvm-commits mailing list