[llvm] r273478 - [MachO] Adding a few missing swapStruct functions

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 14:38:04 PDT 2016


On Wed, Jun 22, 2016 at 2:34 PM, Chris Bieneman <beanz at apple.com> wrote:
> I have a WIP patch that adds obj2yaml/yaml2obj support for mach-o fat files, that will test this. I hope to land the patch later today or tomorrow with test cases. If you’d prefer I can revert the patch until it is used. I committed it separately because it is a self-contained bit of code with no adverse impact.
>

No, assuming you're going to test this somewhere it's fine. I agree
that committing the patch separately is the right thing to do, but,
for the next time, it should either a) explain in the commit message
how it's going to be used or b) add a test.

Thanks!

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list