[PATCH] D21536: [CFLAA] Include externally-visible memory aliasing information in function summaries

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 11:46:11 PDT 2016


george.burgess.iv added inline comments.

================
Comment at: lib/Analysis/CFLAliasAnalysis.cpp:760
@@ +759,3 @@
+  DenseMap<StratifiedIndex, InterfaceValue> InterfaceMap;
+
+  // Our intention here is to record all InterfaceValues that share the same
----------------
Currently, we unify stratifiedsets both upwards and downwards -- the reason behind this is "that's how I interpreted the paper when I wrote StratifiedSets." :P

If you want to fix that, then feel free. And yeah, if we do change stratifiedsets to that model, then my proposed approach is broken.


http://reviews.llvm.org/D21536





More information about the llvm-commits mailing list