[PATCH] D21593: test-suite: Remove lemon benchmark
Chris Matthews via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 22 11:12:43 PDT 2016
cmatthews added a comment.
In http://reviews.llvm.org/D21593#464278, @kristof.beyls wrote:
> Thanks for the analysis!
>
> Interestingly, on the systems I look at most often (linux AArch64 and AArch32), I don't see lemon produce too much noise.
> Anyway, with your analysis, it's clear that lemon doesn't really test quality of compiler code generation, so I agree not to run it as a benchmark.
Forking is a more heavy weight operation on Darwin.
> However, it may still make sense to keep this in the test-suite as a correctness test, in which case it should be just listed under "if(NOT TEST_SUITE_BENCHMARKING_ONLY)"?
Since lemon is a parser, maybe it is okay to totally remove since we have some other benchmarks that represent that class of programs?
The runtime is sub-second everywhere where I looked, so I think it is fine to keep it in if we think there is any chance that it would detect a miscompile.
> Thanks,
>
> Kristof
Repository:
rL LLVM
http://reviews.llvm.org/D21593
More information about the llvm-commits
mailing list