[llvm] r273294 - [codeview] Add support for splitting field list records over 64KB

[Zachary Turner via llvm-commits]

Yea I thought of that too, probably better to not alter the structure when
we dump since the whole point is to see the structure
On Wed, Jun 22, 2016 at 8:25 AM Reid Kleckner <rnk at google.com> wrote:

> I think some tools (dumper & linker) will want to see record split up into
> pieces, and some tools (debugger) will want to see the list as whole. It
> seemed better to me to let the debugger do the record merging when it needs
> it.
>
> On Wed, Jun 22, 2016 at 8:20 AM, Zachary Turner <zturner at google.com>
> wrote:
>
>> What I meant was that it would be cool an LF_FIELDLIST or whatever that
>> was too large would print as a single record instead of printing half, then
>> pritning some more records, and then later printing some more.  But maybe
>> that's not actually desirable.
>>
>> On Wed, Jun 22, 2016 at 8:17 AM Reid Kleckner <rnk at google.com> wrote:
>>
>>> The visitor didn't need any changes, it's all handed by TypeRecords.def.
>>> I also added dumper support in this change and mentioned it in the message.
>>> I forgot to commit the test that exercised it, though, so that went in as
>>> r273355.
>>>
>>> On Tue, Jun 21, 2016 at 9:02 PM, Zachary Turner <zturner at google.com>
>>> wrote:
>>>
>>>> What about updating the visitor to support dumping this?
>>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160622/945f27ee/attachment.html>