[PATCH] D21449: Target independent codesize heuristics for Loop Idiom Recognition

[Chad Rosier via llvm-commits]

mcrosier added a comment.

Hi Sunita,
Just a very broad comment:

Overall, I'm concerned with the complexity of this patch.  Generally, the community prefers small incremental changes as they're easier to review and it's easier to understand the bang we're getting for the buck (i.e., code size reduction vs. implementation complexity).  For example, your first patch might just avoid LIR for loops with multiple BBs.  The follow on patch might avoid idiom recognition in the presence of non-legal stores. The next patch might detemine if the loop is collapsable, which I think could be built into collectStores() to minimize the compile time impact, etc.


Repository:
  rL LLVM

http://reviews.llvm.org/D21449