[PATCH] D21552: [ELF] - Teach llvm-readobj to print dependencies of SHT_GNU_verdef and refactor dumping method.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: test/tools/llvm-readobj/elf-versioninfo.test:71
@@ +70,3 @@
+CHECK-NEXT:     Index: 3
+CHECK-NEXT:     Count: 2
+CHECK-NEXT:     Hash: 175630258
----------------
Count is redundant, no? It is always 1 or 2 and being 2 is visible by Predecessor being present.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:572
@@ +571,3 @@
+
+    if (VD->vd_cnt == 2) {
+      const uint8_t *PAux = P + VD->vd_aux + VD->getAux()->vda_next;
----------------
Produce an error if is > 2.



http://reviews.llvm.org/D21552