[PATCH] D21360: test-suite cmake: Detect test subdirectories when running cmake.
Chris Matthews via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 21 17:49:32 PDT 2016
cmatthews accepted this revision.
cmatthews added a comment.
1. This is a great idea!!!
2. it is okay that it only scans once.
3. I dont think we should check the builddir: I find that counter intuitive.
4. I think a flag is best, it would be great if we can add more than one test suite at a time though. I bet that is done more easily through wildcards? The way I see this used is several test sets checked out side by side (to not muck with the checkouts), so passed via flag makes sense to me.
Ideally I don't want the test suite itself to run by default. The way I see myself using this is checking out a bunch of smaller tests, and combining them as a new bot. So, for instance in my O3 X86 bot, I checkout SPEC, and cool suite 1 and cool suite 2, and with one cmake invocation I have all those suites run in that configuration.
Repository:
rL LLVM
http://reviews.llvm.org/D21360
More information about the llvm-commits
mailing list