[PATCH] D21053: IR: New representation for CFI and virtual call optimization pass metadata.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/Transforms/IPO/CrossDSOCFI.cpp:77
@@ -78,1 +76,3 @@
+/// Extracts a numeric type identifier from an MDNode containing type metadata.
+ConstantInt *CrossDSOCFI::extractNumericTypeId(GlobalObject &GO, MDNode *MD) {
   // This check excludes vtables for classes inside anonymous namespaces.
----------------
GlobalObject argument is now unused.

================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:960
@@ +959,3 @@
+      AddGlobalToEqClass(F);
+    for (GlobalVariable &GV : M->globals())
+      AddGlobalToEqClass(GV);
----------------
I'm surprised we don't have Module::global_objects() yet. It sounds like a great idea.


http://reviews.llvm.org/D21053