[PATCH] D21556: [ELF] - Implemented version script hierarchies.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:1478
@@ -1473,1 +1477,3 @@
 
+unsigned getVersionNameStrTabOffset(StringRef Name) {
+  for (Version &V : Config->SymbolVersions)
----------------
`static size_t`?

================
Comment at: ELF/SymbolListFile.cpp:97
@@ -96,1 +96,3 @@
   expect("}");
+  if (Version.empty() || peek() == ";") {
+    expect(";");
----------------
I'd do

  if (!Version.empty() && peek() != ";")
    Config->SymbolVersions.back().Dependency = next();
  expect(";");


http://reviews.llvm.org/D21556