[PATCH] D21568: Invoke simplifycfg and sroa before instcombine.

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 21 14:39:04 PDT 2016


wmi added a comment.

It may be helpful to provide more background here, especially whether this change affect samplefdo only or it may affect non-fdo mode too. We may need such information to justify the change.


================
Comment at: lib/CodeGen/BackendUtil.cpp:185
@@ -183,2 +184,3 @@
+  PM.add(createSROAPass());
   PM.add(createInstructionCombiningPass());
 }
----------------
This way sroa and cfgsimplify passes will be added before every Instcombine pass. Is it necessary? or it is only needed to add cfgsimplify and sroa for the first instcombine pass before sample fdo annotate?  



http://reviews.llvm.org/D21568





More information about the llvm-commits mailing list